[0003] Align file paths to the exposed attrs #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonringer
changed the title
blaggacao
reviewed
Nov 9, 2024
| ## Meta concerns | ||
|
|
||
| - Collapsing the folders could result in absurdly large directories | ||
| - This is somewhat mitigated by the poly-repo structure. There should only be a few thousand packages in any one directory in a given repo. |
There was a problem hiding this comment.
If performance should ever become a primary concern, I submit to solve it eventually via code generation, in any case other means: maintaining the origin source optimized for readability as this EEP pursues.
csjewell
reviewed
Feb 14, 2025
csjewell
reviewed
Feb 14, 2025
Co-authored-by: Curtis Jewell <perl@csjewell.fastmail.us>
Co-authored-by: Curtis Jewell <perl@csjewell.fastmail.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File paths should align to the attr paths which contain them. Make finding the relevant file easy.