Support 1.21.11

[Jazzkuh]

• Add support for 1.21.11
• Update outdated dependencies for libdisguises and nocheatplus.

[NathanWolf]

Thank you! I was trying to add 1.21.11 support myself, but I ran into some issues at runtime with Paper. Maybe due to the deobfuscation?

Some of the NMS classes had different names than the remapped Spigot bindings I had built against.

Did you find a way around this?

I’m not sure if I ever pushed any of my changes, if not I’ll stash them in a branch and try out yours instead.

[Jazzkuh]

Hi, i have not found any issues regarding the mappings but maybe that is because im testing it on paper, no issues so far!

[NathanWolf]

I just tried latest Paper with my own attempt, and it seems to be working now. So I guess it was just an issue with the early experimental build of Paper I had been using.

Now.. unfortunately your changes have a ton of CheckStyle issues, so they won't build for me. (Do you build with checkstyle turned off, maybe?)

I already pulled them and I really like to avoid doing force-pushes, so I may try to merge my changes back in and replace yours "cleanly" rather than fixing all of the import issues. I started down that path but it was super tedious, basically redoing all the imports which was the bulk of the change in the first place 😅

Anyway, I appreciate your work, I wish I had pushed mine first though, I think it would've saved us both some time!

[NathanWolf]

Hm also that extra commit I'm going to need to find a different way to do that- we can't change the main Magic project to build against 1.21.11, or else now it doesn't work on earlier versions anymore.

One Day I'm going to just make it so latest Magic only works with latest Minecraft, but I'm not quite ready to make that leap just yet 😓

[Jazzkuh]

Haha no worries, the latest commit was mainly me just being me and just building a feature i want myself, didnt really mean for it to be pushed into this PR haha, glad to be of some help!

[Jazzkuh]

And yes i do build with checkstyle off, i don't think i have the patience for it 😂

[NathanWolf]

Oh, ok. What is this custom paper animation thing?

I'm finding that particularly hard to deal with since I'd have to now version the paper compatibility layer :(

[Jazzkuh]

In 1.21.11 you have the ability to use the STAB animation from the new spear, i thought it could be cool for wands since you actually kind of "swing" it.

[Jazzkuh]

I've sent you a video on Discord.

[NathanWolf]

Oh, ok- that sounds neat. But I may be willing to wait for an official Spigot PR, seems like that'd fit nicely into the existing animation API rather than having to be Paper-specific?

https://hub.spigotmc.org/javadocs/spigot/org/bukkit/event/player/PlayerAnimationType.html

[Jazzkuh]

Oh, ok- that sounds neat. But I may be willing to wait for an official Spigot PR, seems like that'd fit nicely into the existing animation API rather than having to be Paper-specific?

https://hub.spigotmc.org/javadocs/spigot/org/bukkit/event/player/PlayerAnimationType.html

I believe there already is an official spigot way, but i could not get that to work, maybe you have more luck? https://hub.spigotmc.org/javadocs/spigot/org/bukkit/inventory/meta/ItemMeta.html#setSwingAnimation(org.bukkit.inventory.meta.components.SwingAnimationComponent)