Skip to content

Elasticsearch connector node js integration#1126

Merged
yansavitski merged 21 commits intomainfrom
elasticsearch-connector-node-js-integration
Mar 27, 2025
Merged

Elasticsearch connector node js integration#1126
yansavitski merged 21 commits intomainfrom
elasticsearch-connector-node-js-integration

Conversation

@yansavitski
Copy link
Contributor

@yansavitski yansavitski commented Mar 18, 2025

Description

Add APIProxyConnector to Elasticsearch Connector for enhances security by keeping API keys and Elasticsearch details hidden from the frontend and shows the recommended way to use Search UI in real-world applications

image

List of changes

  • A working example of the API Proxy connector (client-side).
  • A simple Express.js server implementation using the Elasticsearch connector.
  • Updated sandbox links and examples structure for clarity.
  • Update sandbox ui home page
  • Add typescript to sandbox example
  • Update react version for sandbox example

Associated Github Issues

@yansavitski yansavitski requested a review from a team as a code owner March 18, 2025 14:00
@github-actions
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

joemcelroy
joemcelroy previously approved these changes Mar 19, 2025
Copy link
Member

@joemcelroy joemcelroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - are you planning on adding the documentation changes also to this pr?

@yansavitski
Copy link
Contributor Author

looks good - are you planning on adding the documentation changes also to this pr?

I will. So we can make release right after to have sandbox wroking. Because it requires new ApiProxyConnector, so if we do merge now without release it breaks sandbox

@yansavitski yansavitski force-pushed the elasticsearch-connector-node-js-integration branch from 75ac2aa to 7ecccdf Compare March 25, 2025 16:09
@yansavitski yansavitski force-pushed the elasticsearch-connector-node-js-integration branch from 7ecccdf to 1a990d5 Compare March 25, 2025 16:12
@yansavitski yansavitski requested a review from leemthompo March 25, 2025 16:12
@yansavitski yansavitski requested a review from joemcelroy March 25, 2025 19:40
@leemthompo
Copy link
Contributor

@yansavitski the docs changes look good apart from one detail. I think we need to preserve original custom anchor IDs for headings exactly as they were. We shouldn't create new anchors like tutorials-elasticsearch-connection-and-authentication - instead reuse api-connectors-elasticsearch-connection-and-authentication even in the new files.

This will ensure all existing external links and bookmarks stay valid.

leemthompo
leemthompo previously approved these changes Mar 26, 2025
Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs updates LGTM. Nice 👌.

Comment on lines +18 to +19
- file: tutorials-elasticsearch-production-usage.md
- file: tutorials-elasticsearch-customise-query.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if wanted to swap these two in toc?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, thank you, it was intentional, because previous tutorials are related and last one tutorials more like a standalone

@yansavitski yansavitski merged commit 6b0055d into main Mar 27, 2025
3 of 4 checks passed
@yansavitski yansavitski deleted the elasticsearch-connector-node-js-integration branch March 27, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants