Elasticsearch connector node js integration#1126
Conversation
|
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
joemcelroy
left a comment
There was a problem hiding this comment.
looks good - are you planning on adding the documentation changes also to this pr?
I will. So we can make release right after to have sandbox wroking. Because it requires new ApiProxyConnector, so if we do merge now without release it breaks sandbox |
…h-connector-node-js-integration
75ac2aa to
7ecccdf
Compare
7ecccdf to
1a990d5
Compare
|
@yansavitski the docs changes look good apart from one detail. I think we need to preserve original custom anchor IDs for headings exactly as they were. We shouldn't create new anchors like This will ensure all existing external links and bookmarks stay valid. |
leemthompo
left a comment
There was a problem hiding this comment.
Docs updates LGTM. Nice 👌.
| - file: tutorials-elasticsearch-production-usage.md | ||
| - file: tutorials-elasticsearch-customise-query.md |
There was a problem hiding this comment.
not sure if wanted to swap these two in toc?
There was a problem hiding this comment.
No, thank you, it was intentional, because previous tutorials are related and last one tutorials more like a standalone
Description
Add APIProxyConnector to Elasticsearch Connector for enhances security by keeping API keys and Elasticsearch details hidden from the frontend and shows the recommended way to use Search UI in real-world applications
List of changes
Associated Github Issues