fix: migrate reclient users to siso #767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsanders11
approved these changes
Oct 23, 2025
Member
dsanders11
left a comment
dsanders11
left a comment
There was a problem hiding this comment.
@codebytere, in my testing use_remoteexec = true is still needed or the build won't work. I pushed some commits which back out that part of the change, also change the e-init defaults, and update the tests. 👍
jkleinsc
requested changes
Oct 23, 2025
Member
jkleinsc
left a comment
jkleinsc
left a comment
There was a problem hiding this comment.
We should explicitly set use_reclient to false when using siso because autoninja does some weird hybrid siso/reclient otherwise.
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
jkleinsc
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reclient is disabled - everyone should be using either
noneorsisoat this point.