fix: parsing signWithParams with double quotes#75
Open
tniezurawski wants to merge 1 commit intoelectron:mainfrom
Open
fix: parsing signWithParams with double quotes#75tniezurawski wants to merge 1 commit intoelectron:mainfrom
signWithParams with double quotes#75tniezurawski wants to merge 1 commit intoelectron:mainfrom
Conversation
|
Thanks! I struggled to choose the best solution of the tree proposals I had and then forgot =D |
erikian
reviewed
Nov 11, 2025
Member
erikian
left a comment
erikian
left a comment
There was a problem hiding this comment.
Thanks for the PR! Could you provide a test case?
Author
|
@erikian Will do 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #45.
Solution by @ShGKme (thank you!). I only raised a PR with the change as I think it's valuable to spread the fix. Especially because more and more people will switch to Cloud HSM providers, they will run into the problem where
/cspwon't be properly parsed andsigntoolwill fail (silently).