Skip to content

Silence some warnings #1488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremypw merged 8 commits into from
Apr 22, 2025
Merged

Silence some warnings #1488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ddd0260
Fix warning on startup
Nov 25, 2024
744a0f6
Fix warning on rename
Nov 25, 2024
4969019
Merge branch 'master' into jeremypw/silence-some-warnings
jeremypw Dec 18, 2024
b84d5b4
Merge branch 'master' into jeremypw/silence-some-warnings
jeremypw Jan 21, 2025
d39525c
Merge branch 'master' into jeremypw/silence-some-warnings
jeremypw Feb 8, 2025
337658a
Merge branch 'master' into jeremypw/silence-some-warnings
zeebok Mar 7, 2025
80ca8d3
Remove stray pasted text
jeremypw Mar 7, 2025
04fc336
Merge branch 'master' into jeremypw/silence-some-warnings
jeremypw Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/MainWindow.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -604,6 +604,7 @@ namespace Scratch {
title = _("%s - %s").printf (doc.get_basename (), base_title);

toolbar.set_document_focus (doc);

folder_manager_view.select_path (doc.file.get_path ());

// Must follow setting focus document for editorconfig plug
Expand Down
6 changes: 5 additions & 1 deletion src/Widgets/SourceList/SourceList.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -870,7 +870,11 @@ public class SourceList : Gtk.ScrolledWindow {
return items.has_key (item);
}

public void update_item (Item item) requires (has_item (item)) {
public void update_item (Item item) {
if (!has_item (item)) {
return;
}

assert (root != null);

// Emitting row_changed() for this item's row in the child model causes the filter
Expand Down