Skip to content

Conversation

@szepeviktor
Copy link
Contributor

Please update the lock file.
Thanks.

@leonstafford
Copy link
Contributor

updated lock with 4ad7b0b and adjusted phpstan.neon

got some new property visibility errors

@szepeviktor szepeviktor deleted the patch-2 branch September 25, 2020 18:04
@szepeviktor
Copy link
Contributor Author

e.g.

 ------ --------------------------------------------------------------------
  Line   Page.php
 ------ --------------------------------------------------------------------
  31     Property SimplerStatic\Page::$found_on_id is never written, only
         read.
 ------ --------------------------------------------------------------------

$found_id is private so will not work in src/Fetch_Urls_Task.php:288

Am I wrong?

@leonstafford
Copy link
Contributor

I'm just a bit concerned about the weird effects I was seeing originally and would need to run code to confirm if what you've got in the #6 and #5 still produce that issue.

Let me get back to you on those. Just doing some work on https://lokl.dev which will aid my functional testing

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Sep 25, 2020

I see. Magic __get() from static::$columns.
Then it's time write a service for PHPStan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants