feat: add UUID support to messages #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add UUID column to messages table matching the implementation used for conversations. This allows systems to reference messages without exposing database IDs. - Add migration to add uuid column to messages table - Update Message model to use HasUuids trait - Configure uniqueIds() method to use uuid column - Update API documentation to include uuid property
✅ Deploy Preview for converse-php canceled.
|
- Move UUID column from separate migration to core messages table migration - Add converse:upgrade command for existing installations - Add CHANGELOG.md to document breaking changes - Update installation docs with upgrade instructions BREAKING CHANGE: Messages table now includes UUID column by default. Run `php artisan converse:upgrade` for existing installations.
The converse:upgrade command now: - Adds the UUID column to the messages table - Automatically generates UUIDs for all existing messages - Shows progress bar for large datasets - Updates documentation to reflect this behavior
- Import Message model directly instead of weird class string usage - Use chunk() instead of get() to handle potentially millions of messages - Process messages in batches of 100 for memory safety - Count total messages upfront for accurate progress bar - No transaction so command can be resumed if it fails partway
- Use chunkById() for better performance with large datasets - Use bulk upsert() instead of individual updates - Use Str::uuid()->toString() for clarity - Batch progress bar updates for better performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
uuidcolumn to messages tableHasUuidstraituniqueIds()method to use the uuid columnBreaking Changes
While this PR does introduce breaking changes, the impact is intended to be minimized by the introduction of a an upgrade command.
Test plan