refactor: make upgrade command specific to UUID migration #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change command signature from converse:upgrade to converse:upgrade-uuid - Update command description to be specific about UUID functionality - Update documentation to reflect new command name This allows for future upgrade commands without conflicts.
✅ Deploy Preview for converse-php ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
converse:upgrade-uuidChanges
converse:upgradetoconverse:upgrade-uuidWhy?
As discussed, having a general
converse:upgradecommand could cause conflicts if we need other upgrade paths in the future. Making it specific to the UUID upgrade allows us to add other upgrade commands likeconverse:upgrade-indexes,converse:upgrade-columns, etc. without conflicts.