Migrate to OCaml 4.12.0 and Dune build system, add GitHub workflow with tests#85
Open
andreyz4k wants to merge 9 commits intoellisk42:masterfrom
Open
Migrate to OCaml 4.12.0 and Dune build system, add GitHub workflow with tests#85andreyz4k wants to merge 9 commits intoellisk42:masterfrom
andreyz4k wants to merge 9 commits intoellisk42:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds several features:
Caveats:
.mlsource files that are not part of any binary mentioned in thedunefile, so I've fixed only linter errors in them, without updating them to the last OCaml version.regexestest is not working (in master as well), so it is disabled in the workflow. Unfortunately, there is noallow-failoption in GitHub Actions at the moment.logotests sometimes fails on empty json, probably because of a crash, reproduces on master as well, the error is muted