Skip to content

Conversation

@ryonakano
Copy link
Contributor

Fixes #11

Changes Summary

@ryonakano ryonakano requested a review from teamcons July 23, 2025 15:06
@teamcons
Copy link
Collaborator

Do not worry about the Linter - We still have to clean up the old code

I will check when i have time for this
Much thanks for your efforts :)

@ryonakano ryonakano force-pushed the ryonakano/fix-crash branch from 0ff67cf to 3731110 Compare July 23, 2025 15:10
@teamcons
Copy link
Collaborator

Cannot test for ARM, but works as usual here so LGTM

@teamcons teamcons merged commit f211b58 into main Jul 23, 2025
1 of 2 checks passed
@teamcons teamcons deleted the ryonakano/fix-crash branch July 23, 2025 16:58
@teamcons
Copy link
Collaborator

thank you!

@teamcons
Copy link
Collaborator

teamcons commented Sep 9, 2025

I somehow didnt catch that (i thought it was libportal quirk), but this implementation works only when the app was previously closed.
If i call it when a window is already there, it stays in the remote instance, and the primary Cherrypick instance ignores it.

Ive spent a lot of time trying to make something like this work without a command_line override in another app, but to properly handle desktop actions, it seems necessary.
Except for Switchboard which handles it as an open(), all other eOS apps with Desktop Action act the same: if the app is already open, the desktop action does nothing, because it isnt picked by the primary instance

https://valadoc.org/gio-2.0/GLib.ApplicationCommandLine.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Possibly coredumps on arm64?

3 participants