Skip to content

mint - add CLN support#139

Merged
elnosh merged 2 commits intomainfrom
cln-support
Apr 5, 2025
Merged

mint - add CLN support#139
elnosh merged 2 commits intomainfrom
cln-support

Conversation

@elnosh
Copy link
Owner

@elnosh elnosh commented Mar 24, 2025

following up on #125 to add support for CLN.

@elnosh elnosh linked an issue Mar 24, 2025 that may be closed by this pull request
@elnosh elnosh force-pushed the cln-support branch 4 times, most recently from c589b6b to f81700c Compare March 24, 2025 20:18
@elnosh
Copy link
Owner Author

elnosh commented Mar 25, 2025

@0ceanSlim followed-up on your PR here. Made some small changes and fixed some tests that were failing.

Lmk if you could give it a quick run. That would be much appreciated

@0ceanSlim
Copy link
Contributor

--- FAIL: TestPendingProofs (15.57s)

Looks like this is the only one failing!

Great work on all this testing!!

@elnosh
Copy link
Owner Author

elnosh commented Mar 26, 2025

--- FAIL: TestPendingProofs (15.57s)

Looks like this is the only one failing!

ya that one was weird. Think it's fixed now.

@0ceanSlim
Copy link
Contributor

Looks all good to me. If everything is working and you're happy I can look at making some small readme changes to let the user know how to make a rune just for this, how to format the rune file/config for CLN.

@elnosh
Copy link
Owner Author

elnosh commented Mar 27, 2025

Looks all good to me. If everything is working and you're happy I can look at making some small readme changes to let the user know how to make a rune just for this, how to format the rune file/config for CLN.

cool, yeah go ahead

@0ceanSlim
Copy link
Contributor

Can you try making a rune with this command and let me know if all the tests pass?
lightning-cli createrune -k "restrictions"='[["method=invoice"],["method=getinfo"],["method=listinvoices"],["method=pay"],["method=listpays"],["method=waitinvoice"]]'

Also the file that contains the rune, how is it formatted in that file? Trying to get the readme updated today so we can get this merged!

@elnosh
Copy link
Owner Author

elnosh commented Apr 5, 2025

Can you try making a rune with this command and let me know if all the tests pass? lightning-cli createrune -k "restrictions"='[["method=invoice"],["method=getinfo"],["method=listinvoices"],["method=pay"],["method=listpays"],["method=waitinvoice"]]'

we can do that here #144

@elnosh elnosh merged commit 4d3aebf into main Apr 5, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for CLN implementation

2 participants