Skip to content

cashurpc#6

Draft
gohumble wants to merge 8 commits intoelnosh:mainfrom
gohumble:cashurpc
Draft

cashurpc#6
gohumble wants to merge 8 commits intoelnosh:mainfrom
gohumble:cashurpc

Conversation

@gohumble
Copy link

No description provided.

gohumble added 4 commits March 17, 2024 10:46
Added new protobuf definitions to the cashu RPC handling framework for managing states and state proofs. These message types will facilitate state checking and updating. Protobuf definitions include `PostCheckStateRequest`, `PostCheckStateResponse`, and `States` among others.
# Conflicts:
#	cmd/nutw/nutw.go
#	wallet/client.go
#	wallet/storage/bolt.go
#	wallet/storage/storage.go
#	wallet/wallet.go
gohumble added 4 commits May 3, 2024 13:33
# Conflicts:
#	cashu/cashu.go
#	cashu/nuts/nut01/nut01.go
#	cashu/nuts/nut02/nut02.go
#	cashu/nuts/nut03/nut03.go
#	cashu/nuts/nut04/nut04.go
#	cashu/nuts/nut05/nut05.go
#	cashu/nuts/nut06/nut06.go
#	cmd/nutw/nutw.go
#	go.mod
#	go.sum
#	mint/config.go
#	mint/db.go
#	mint/lightning/lnd.go
#	mint/mint.go
#	mint/server.go
#	wallet/storage/bolt.go
#	wallet/wallet.go
@gohumble
Copy link
Author

gohumble commented May 4, 2024

resolved changes from @callebtc
todo:

  • add removed .env.wallet.example
  • refactor MINT_CONTACT_INFO ?
  • test mint using https://cashu.me
  • add Dockfile

@elnosh
Copy link
Owner

elnosh commented May 4, 2024

2. refactor MINT_CONTACT_INFO ?

to what does it need to change?

@gohumble
Copy link
Author

gohumble commented May 4, 2024

Tthe contact infos currently defined as an array of arrays with at most 2 elements. The first element represents the key, while the second element is the value. This should probably be update to an array of objects.

current state:

"contact": [
    ["email", "contact@me.com"],
    ["twitter", "@me"],
    ["nostr" ,"npub..."]
  ]

desired state (already implemented in this PR)

"contact": [
  {"type":"email", "value":"contact@me.com"},
  {"type":"twitter", "value":"@me"},
  {"type":"nostr" , "value":"npub..."}
]

I am going to open a new pull request in the nuts repository and propose the change to the protocol there.

@gohumble
Copy link
Author

gohumble commented May 4, 2024

cashubtc/nuts#117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants