Skip to content

Fix OS command injection in scrape_github (CWE-78) #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emcf merged 1 commit into from
Mar 3, 2026
+9 −6
Merged

Fix OS command injection in scrape_github (CWE-78) #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions thepipe/scraper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
chunk_by_length,
chunk_agentic,
)
import tempfile
import mimetypes
import dotenv
from magika import Magika
Expand Down Expand Up @@ -1048,14 +1047,18 @@ def scrape_github(
# make new tempdir for cloned repo
with tempfile.TemporaryDirectory() as temp_dir:
# requires git
exit_code = os.system(
f'git clone --branch "{branch}" --single-branch {github_url} "{temp_dir}" --quiet'
)
if exit_code != 0:
import subprocess

try:
subprocess.run(
["git", "clone", "--branch", branch, "--single-branch", github_url, temp_dir, "--quiet"],
check=True,
)
except subprocess.CalledProcessError as e:
raise RuntimeError(
f"git clone failed for {github_url} at branch '{branch}'. "
"Verify the repository URL and branch name."
)
) from e
files_contents = scrape_directory(
dir_path=temp_dir,
inclusion_pattern=inclusion_pattern,
Expand Down
Loading