Conversation
NewPropFindResponse uses callbacks to lazily build the response. However, some props are static: they don't require any processing to generate. Add a small helper to reduce boilerplate a bit.
oliverpool
approved these changes
Oct 4, 2024
oliverpool
left a comment
oliverpool
left a comment
There was a problem hiding this comment.
This change looks like a net improvement!
It would be nice to merge it, to prevent conflicts for future merge requests (I was almost ready to also make a fix for thunderbid, like #170 but with tests :)
|
|
||
| type PropFindFunc func(raw *RawXMLValue) (interface{}, error) | ||
|
|
||
| func PropFindValue(value interface{}) PropFindFunc { |
There was a problem hiding this comment.
Would PropFindStatic be a name easier to grasp?
Suggested change
| func PropFindValue(value interface{}) PropFindFunc { | |
| func PropFindStatic(value interface{}) PropFindFunc { |
|
looks cleaner |
|
🎆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NewPropFindResponse uses callbacks to lazily build the response. However, some props are static: they don't require any processing to generate. Add a small helper to reduce boilerplate a bit.