Check whether the notification supports action in makoctl invoke
#600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the action is not supported by the given notification, we return an error condition and report this on the terminal. It is useful to know whether the notification was successfully invoked, for example, I have this in my `hyperland` configuration to deal with the newest notification (similar to clicking on it): ``` bind = $MOD, period, exec, makoctl invoke || makoctl dismiss ``` An alternative approach for my use-case would be to have the `InvokeAction` dismiss the notification when the `default` action is sent to an action-less notification. The chosen approach is more versatile, as the user of `makoctl invoke` can decide what behavior to chose.
arximboldi
added a commit
to arximboldi/dotfiles
that referenced
this pull request
Sep 3, 2025
Owner
|
Rather than checking in makoctl (which is racy), could we check in dbus/mako.c? |
Author
|
That makes sense. I was just inspired by the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the action is not supported by the given notification, we return an error condition and report this on the terminal.
It is useful to know whether the notification was successfully invoked, for example, I have this in my
hyperlandconfiguration to deal with the newest notification (similar to clicking on it):An alternative approach for my use-case would be to have the
InvokeActiondismiss the notification when thedefaultaction is sent to an action-less notification. The chosen approach is more versatile, as the user ofmakoctl invokecan decide what behavior to chose.