Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds full PHP 8.3 support to errbit-php and significantly improves test coverage from ~73% to ~88%.
Key Changes
PHP 8.3 Compatibility Fixes:
Dockerfileto usephp:8.3-fpm-alpinewith PECL-based Xdebug installationWriterInterfaceto use\Throwableinstead of removedErrorInterfaceBaseError,Notice,Warning,Error,Fatal) with$fileand$backtraceparametersErrorHandlers::onShutdown()parameter order forFatalconstructorErrorHandlers::onException()to pass correct arguments toConverter::convert()Errbit::shouldNotify()null access issue withignore_user_agent(integer)cast with(int)inConverter.phpprint_r()second parameter to useboolinstead ofint(PHP 8.3 strict)ErrorInterface.phpTest Coverage Improvements (+1200 lines of tests):
ErrbitTest.phpwith 15+ new tests (singleton, configure, onNotify, shouldNotify, ignore_user_agent)ErrorHandlersTest.phpwith tests for onError, onException, different error typesBaseErrorTest.phpfor error class constructorsNoticeTest.phpwith ~25 tests for XML generation, filtering, formattingXmlBuilderTest.phpwith XmlBuilder-specific testsSocketWriterTest.phpwith connection scheme and payload testsGuzzleWriterTest.phpwith async/sync write testsCI/CD Updates:
Test Plan
XDEBUG_MODE=coverage php bin/phpunit --testsuite UnitTests --coverage-text