Feature: Add SpruceOS/{spruce} output token support #1982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added all systems that Spruce supports that Igir supports
Based on Onion OS test for known extensions Based on ROMM test for unknown extensions, as Spruce supports Arduboy the Onion test was not appropriate
Add {spruce} token explanation
Fixed numerous whitespace typos from "hand writing" file
Add spruceos.md to usage/handheld with basic usage
Added {spruce} token to tokens.md
Updated mkdocs.yml
👋 WelcomeThank you for your first pull request, @GreyhameAU! If you haven't yet, please familiarize yourself with Igir's contribution guidelines. Some GitHub Actions CI workflows may not automatically run for you due to GitHub's security best practices, so a maintainer may need to manually approve the workflows to run. As a result, it is important to make sure tests pass locally before submitting a pull request to help ensure a fast review. Thank you! Comment generated by the GitHub First Interaction workflow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for a new output token to support SpruceOS:
{spruce}SpruceOS is an overhaul system similar to OnionOS, but supports more powerful hardware so allows more consoles than the ones supported in OnionOS. SpruceOS just had a major release adding support to the much more powerful Miyoo Flip, so the differences between SpruceOS and OnionOS's supported devices has grown significantly and I believe warrants being supported as a separate output token now.
My programming skills are not my current strength, so a lot of this is just from copying the
{onion}token implementation, though in the outputFactorytest.ts it is hybridised with the{romm}implementation with the intention to catch bad extensions, as SpruceOS does support the Arduboy the OnionOS test was not appropriate.I have included updated documentation for this change as well, though more than happy to make any changes to it.
Pull request checklist
npm testhas been run locally for your change, to validate: