class_<T>.constructor to accept std::function and function object#9051
Merged
kripken merged 1 commit intoemscripten-core:incomingfrom Jul 25, 2019
Merged
Conversation
Contributor
Author
Enable `class_<T>.constructor` to accept both `std::function` and function object types. This is useful in scenarios where you want a stateful function object for purposes such as gathering statistics or performing other generic functionality on each call.
hkleynhans
force-pushed
the
functors_as_class_constructors
branch
from
b5146ce to
2f70512
Compare
wingo
approved these changes
Jul 23, 2019
Contributor
wingo
left a comment
wingo
left a comment
There was a problem hiding this comment.
LGTM. Nice simplification to fold the ThisType param into the arguments.
Member
|
Thanks for the PR @hkleynhans! And thanks for reviewing @wingo! |
Contributor
Author
Contributor
|
#12973 reverts a part of this PR that broke a couple of other projects. cc: @hkleynhans |
belraquib
pushed a commit
to belraquib/emscripten
that referenced
this pull request
Dec 23, 2020
…on object (emscripten-core#9051) Enable `class_<T>.constructor` to accept both `std::function` and function object types. This is useful in scenarios where you want a stateful function object for purposes such as gathering statistics or performing other generic functionality on each call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable
class_<T>.constructorto accept bothstd::functionandfunction object types. This is useful in scenarios where you want a
stateful function object for purposes such as gathering statistics or
performing other generic functionality on each call.