You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 11, 2025. It is now read-only.
The getLatestSpecVersion function now defaults to returning 1014. Ensure this behavior is intentional and does not disrupt existing workflows or compatibility with other parts of the system.
if (network =='canary'|| network =='canary-matrixchain') {
return1013;
}
return1014;
}
The addition of case 1014 in the productionSpec function should be validated with tests to ensure it behaves as expected and does not introduce regressions.
Why: Adding a fallback value ensures robustness by preventing potential runtime errors if p.v1014 is undefined. This is a practical enhancement to the code's reliability.
7
General
Ensure the default spec version logic is correctly implemented for all networks
Verify that returning 1014 as the default spec version is intentional and aligns with the expected behavior for all networks.
Why: Verifying the logic for returning 1014 as the default spec version is important to ensure it aligns with the intended behavior. However, the suggestion is not actionable and only prompts verification, reducing its impact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Enhancement
Description
Updated production metadata to support version
v1014.Added export for
v1014in production constants.Adjusted latest spec version to
1014in general handler.Updated package version to
2.2.0inpubspec.yaml.Changes walkthrough 📝
matrix.dart
Add support for metadata version `v1014` in matrix constantslib/consts/matrix/matrix.dart
productionLatestto returnv1014.1014inproductionSpec.general.dart
Update latest spec version to `1014` in handlerlib/handler/general.dart
getLatestSpecVersionto return1014for production.production.dart
Export metadata version `v1014` in production constantslib/consts/matrix/production/production.dart
v1014in production constants.v1014.dart
Add metadata file for version `v1014`lib/consts/matrix/production/v1014.dart
v1014.pubspec.yaml
Bump package version to `2.2.0`pubspec.yaml
2.1.1to2.2.0.