You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 11, 2025. It is now read-only.
Confirm that the logic for returning 1050 as the latest spec version for canary-relaychain is correct and does not conflict with other network conditions.
Why: The suggestion improves the robustness of the getLatestSpecVersion function by ensuring unsupported network values are handled explicitly, which could prevent runtime errors and unexpected behavior. This is a meaningful enhancement to the code.
8
General
Avoid hardcoding version in canaryLatest
Ensure that the canaryLatest function returns the correct and most up-to-date version, as hardcoding c.v1050 could lead to maintenance issues when newer versions are added.
-return c.v1050;+return c.v1050; // Consider dynamically determining the latest version to avoid future maintenance issues.
Suggestion importance[1-10]: 7
Why: The suggestion highlights a valid concern about maintainability, as hardcoding the version in canaryLatest could lead to issues when newer versions are introduced. However, the improved code does not resolve the issue but only adds a comment, making it less impactful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Enhancement, Dependencies
Description
Added support for new Canary version
v1050.Updated metadata and constants for Canary relay chain.
Bumped project version to
2.3.0and updated dependencies.Exported new
v1050file for Canary metadata.Changes walkthrough 📝
enjin.dart
Update Canary metadata to include `v1050`lib/consts/enjin/enjin.dart
canaryLatestto returnv1050.v1050incanarySpec.general.dart
Update latest spec version for Canary relay chainlib/handler/general.dart
getLatestSpecVersionto return1050forcanary-relaychain.canary.dart
Export new Canary metadata file `v1050`lib/consts/enjin/canary/canary.dart
v1050.dartfile for Canary metadata.pubspec.yaml
Update project version and dependenciespubspec.yaml
2.3.0.shelf,polkadart,substrate_metadata,polkadart_scale_codec,logging, andlints.