You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 11, 2025. It is now read-only.
tallesborges
changed the title
[PLA-2300] Add v1030 and v1060 metadata versions with fetch reminder
[PLA-2300] Add v1030 and v1060 metadata versions
Oct 27, 2025
Ensure that the new canary version v1060 is actually implemented and exported in canary sources and that downstream code expecting v1060 is compatible. Verify that any associated spec or metadata consumers recognize 1060.
Verify that v1030 exists and is correctly exported; confirm all places relying on canaryLatest now correctly reference v1030 and that spec handling and consumers are updated.
The reminder echo is helpful, but consider making it actionable (e.g., failing if cases are missing) to prevent omissions when adding new versions.
update_exports "$base""$category""$environment""$version"echo"$network: v$version -> lib/consts/$category/$environment/v$version.dart"echo"REMINDER: Update lib/consts/$category/$category.dart to include case $version in the ${environment}Spec function"
}
Make the reminder actionable by automatically grepping for the case $version entry and warning if missing. This reduces human error causing missing switch cases at runtime.
echo "REMINDER: Update lib/consts/$category/$category.dart to include case $version in the ${environment}Spec function"
+spec_file="lib/consts/$category/$category.dart"+if ! grep -q "case $version" "$spec_file"; then+ echo "WARNING: Missing 'case $version' in ${environment}Spec within $spec_file" >&2+fi
Suggestion importance[1-10]: 6
__
Why: This automates a manual reminder into a concrete warning, reducing human error; it's accurate to the context and low-risk, though not critical to functionality.
Low
Possible issue
Add safe fallback return
Ensure c.v1060 is defined and non-empty to avoid returning an undefined or placeholder constant from canaryLatest(). If v1060 isn't available at runtime, fall back to the previous stable version.
String canaryLatest() {
- return c.v1060;+ // Fallback to previous known stable if v1060 is unavailable/empty.+ return (c.v1060.isNotEmpty) ? c.v1060 : c.v1050;
}
Suggestion importance[1-10]: 3
__
Why: The fallback idea is reasonable but speculative; c.v1060 is likely a defined constant and adding .isNotEmpty assumes a String and non-empty contract not evident in the diff.
Low
Provide defensive fallback
Guard against c.v1030 being missing or empty to prevent runtime issues when resolving the latest spec. Provide a fallback to the last known stable v1023.
String canaryLatest() {
- return c.v1030;+ // Fallback to previous known stable if v1030 is unavailable/empty.+ return (c.v1030.isNotEmpty) ? c.v1030 : c.v1023;
}
Suggestion importance[1-10]: 3
__
Why: Similar to the first, it adds a defensive fallback without evidence c.v1030 could be empty; .isNotEmpty type assumption may not hold, offering limited, possibly incorrect value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Enhancement, Documentation
Description
Add Matrix canary v1030 metadata
Add Enjin canary v1060 metadata
Update latest canary pointers
Script reminder to update spec cases
Diagram Walkthrough
File Walkthrough
6 files
Point canary latest to v1060 and add spec casePoint canary latest to v1030 and add spec caseExport new v1060 canary metadataExport new v1030 canary metadataAdd reminder to update spec switch casesAdd Matrix canary metadata v10301 files
Add repo workflow and PR guidelines1 files