You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The new v-if="useAppStore().advanced" directives require useAppStore to be imported in the component. Verify that useAppStore is available to avoid runtime errors.
<FormInputv-if="useAppStore().advanced"v-model="signingAccount"
name="signingAccount"
label="Signing Account"
description="The wallet used to sign and broadcast the transaction. By default, this is the wallet daemon."
/>
Why: The GraphQL argument must use signingAccount: instead of $signingAccount: to match the server schema and avoid syntax errors.
High
General
Use store instance in template
Avoid calling the store function in the template. Instead, import useAppStore in <script setup>, assign it to a constant, and reference its advanced property for better performance and consistency.
<FormInput
- v-if="useAppStore().advanced"+ v-if="appStore.advanced"
v-model="signingAccount"
name="signingAccount"
label="Signing Account"
description="The wallet used to sign and broadcast the transaction. By default, this is the wallet daemon."
/>
+<script setup>+import { useAppStore } from '~/store';+const appStore = useAppStore();+// ...+</script>+
Suggestion importance[1-10]: 6
__
Why: Using useAppStore() directly in the template can cause unnecessary function calls; importing the store in <script setup> and referencing appStore.advanced improves performance.
Low
Conditionally include signingAccount
Guard against sending an empty or default signingAccount. Only include it in the payload when the user has explicitly set a non‐empty value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Enhancement
Description
Add
signingAccountfield to advanced formsInclude
signingAccountin API payloadsUpdate GraphQL mutations to accept
signingAccountInitialize
signingAccountref in componentsChanges walkthrough 📝
13 files
Include `signingAccount` input in batch mint formAdd `signingAccount` to collection creation formAdd `signingAccount` input to beam delete slide-overInclude `signingAccount` in collection approval formAdd advanced `signingAccount` field to freeze UIAdd `signingAccount` option to fuel tank accountsInclude `signingAccount` in cancel listing slide-overAdd advanced `signingAccount` to token approval formPass `signingAccount` in API service methodsExtend Beam API with `signingAccount` variableAdd `signingAccount` support in Collection APIInclude `signingAccount` in FuelTank API callsUpdate `Freeze` mutation to accept `signingAccount`43 files