You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Reintroduce the metadataHash field to the signing payload to ensure compatibility with the expected payload schema. Default to the full zero hash when transaction.signingPayloadJson.metadataHash === '00'.
Why: The metadataHash field was removed but is required by the SignerPayloadJSON schema for correct transaction signing; the suggestion accurately reintroduces the logic with the zero fallback.
Medium
Re-add mode field
Add the mode property back into the signing payload so that the payload matches the original signing payload JSON structure and supports correct transaction mortality handling.
Why: The mode property is necessary for proper transaction mortality handling and was removed in the PR; restoring it ensures the payload matches the expected structure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Bug fix
Description
Removed metadataHash computation logic
Deleted metadataHash field from payloadToSign
Deleted mode field from payloadToSign
Simplified SignerPayloadJSON construction
Changes walkthrough 📝
transaction.ts
Simplify signing payload propertiesresources/js/store/transaction.ts
metadataHashproperty from SignerPayloadJSONmodeproperty from SignerPayloadJSON