Draft
Conversation
rahulporuri
reviewed
Apr 28, 2020
| ets_repo_path = Path(__file__).parent | ||
|
|
||
| dependencies = [ | ||
| { |
Contributor
There was a problem hiding this comment.
Is there a specific reason why you chose this format of lists of dicts? I was wondering why not a dict of lists e.g.
{
'edm': ['', '', ''],
'pip': ['', '', ''],
}
In the current implementation, the dev/user doesn't get an overview of all dependencies in one glance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposal to add common CI infrastructure as part of the ets project. The intent is that these would be used by ets projects CI infrastructure.
The basics are working, but tests are needed, plus agreement that this is useful.