Fix missing position_ids argument when recompute_granularity == full#86
Open
xingyaoww wants to merge 1 commit intoepfLLM:mainfrom
Open
Fix missing position_ids argument when recompute_granularity == full#86xingyaoww wants to merge 1 commit intoepfLLM:mainfrom
xingyaoww wants to merge 1 commit intoepfLLM:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When set
--recompute_granularity fullfor finetuning, we will see traceback like this:When tracing back, we find that reshape_for_broadcast is only called when position_ids is None, which means the position_ids was NOT passed to each transformer layer when
--recompute_granularity full(finetuning did work when--recompute_granularity selective).I further chased the error down to
megatron/model/transformer.py, it turns out there are some missing arguments when calling the checkpoint function through_checkpointed_forward, which I fixed in this PR.