Skip to content

Option to make participant data anonymous#1453

Merged
felixrindt merged 6 commits intomainfrom
hide-participant-data
Jan 3, 2025
Merged

Option to make participant data anonymous#1453
felixrindt merged 6 commits intomainfrom
hide-participant-data

Conversation

@felixrindt
Copy link
Member

@felixrindt felixrindt commented Dec 22, 2024

  • user docs
  • translate
  • frontend
  • model
  • api
    • tests

@felixrindt felixrindt added the [C] feature New feature or request label Dec 22, 2024
@coveralls
Copy link

coveralls commented Dec 22, 2024

Coverage Status

coverage: 83.88% (+0.006%) from 83.874%
when pulling ce6964d on hide-participant-data
into 9e8f868 on main.

@felixrindt felixrindt marked this pull request as ready for review December 22, 2024 11:27
@felixrindt felixrindt requested a review from jeriox December 22, 2024 11:28
@felixrindt felixrindt changed the title show-participant-data and API Option to make participant data anonymous Dec 22, 2024
@felixrindt
Copy link
Member Author

@jeriox Do you think we should show all participant info if the viewing user has view_userprofile permissions? In the API they would be allowed to view all participations of all users. I don't like the inconsistency...

@jeriox
Copy link
Contributor

jeriox commented Dec 23, 2024

@jeriox Do you think we should show all participant info if the viewing user has view_userprofile permissions? In the API they would be allowed to view all participations of all users. I don't like the inconsistency...

yeah I think so. viewing the userprofile includes viewing working hours, which in turn reveals participations. so they should be visible on the event page as well.

@felixrindt felixrindt requested a review from jeriox January 3, 2025 19:12
@felixrindt felixrindt force-pushed the hide-participant-data branch from 872a499 to ce6964d Compare January 3, 2025 19:19
@felixrindt felixrindt enabled auto-merge (rebase) January 3, 2025 19:20
@felixrindt felixrindt merged commit 92009e8 into main Jan 3, 2025
15 checks passed
@felixrindt felixrindt deleted the hide-participant-data branch January 3, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[C] feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants