Skip to content

add dynamic_settings#1455

Merged
felixrindt merged 7 commits intomainfrom
dynamic-settings
Jan 5, 2025
Merged

add dynamic_settings#1455
felixrindt merged 7 commits intomainfrom
dynamic-settings

Conversation

@felixrindt
Copy link
Member

@felixrindt felixrindt commented Dec 26, 2024

The goal is that at least some settings used after project initialization can be customized by plugin code.
I though about replacing the django.conf.settings object we use everywhere, but that caused circular-import-hell. Now it's very explicit when the dynamic mechanism is used. I like that we can use any prefix or other mechanism to provide defaults in settings.py using defaults from the env-file (feel free to suggests other names/mechanisms).

TODO

  • add dynamic settings object
  • migrate SITE_URL and USERCONTENT_URL
  • migrate brand_logo signal to brand_static_path
  • add platform name and primary color

@felixrindt felixrindt added the [C] enhancement Changes to an existing feature making it better label Dec 26, 2024
@felixrindt felixrindt requested a review from jeriox December 26, 2024 12:55
@coveralls
Copy link

coveralls commented Dec 26, 2024

Coverage Status

coverage: 83.904% (+0.03%) from 83.874%
when pulling 18d50f5 on dynamic-settings
into 8707358 on main.

@felixrindt felixrindt force-pushed the dynamic-settings branch 2 times, most recently from 14a13e3 to 4b6c311 Compare January 5, 2025 17:17
@felixrindt felixrindt merged commit 6796db4 into main Jan 5, 2025
15 checks passed
@felixrindt felixrindt deleted the dynamic-settings branch January 5, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[C] enhancement Changes to an existing feature making it better

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants