Skip to content

allow multiple comments per participation#1457

Merged
jeriox merged 18 commits intomainfrom
participation-comment
Apr 13, 2025
Merged

allow multiple comments per participation#1457
jeriox merged 18 commits intomainfrom
participation-comment

Conversation

@jeriox
Copy link
Contributor

@jeriox jeriox commented Jan 5, 2025

closes #230 closes #1214

ToDo

  • set author
  • add previous comments as readonly to form
  • proper design
  • controls for visibility
  • fix tests
  • automatic comments for state change?

@jeriox jeriox added the [C] feature New feature or request label Jan 5, 2025
@jeriox jeriox force-pushed the participation-comment branch from eae8cbe to a30d7ba Compare March 3, 2025 19:59
@jeriox jeriox requested a review from felixrindt March 3, 2025 20:07
@jeriox jeriox marked this pull request as ready for review March 3, 2025 20:07
@jeriox jeriox force-pushed the participation-comment branch from 44606ba to 16dfe9d Compare March 3, 2025 20:55
@coveralls
Copy link

coveralls commented Mar 3, 2025

Coverage Status

coverage: 83.849% (-0.1%) from 83.97%
when pulling 9b1785e on participation-comment
into 3178e39 on main.

@jeriox
Copy link
Contributor Author

jeriox commented Mar 3, 2025

@felixrindt I played around with the state change stuff a bit.
Finding the appropriate modellogging entries is easy: LogEntry.objects.filter(content_object_id=self.instance.pk, content_type=ContentType.objects.get_for_model(instance.__class__)))
But displaying them in a useful way would require merging them with the comments and sorting them afterwards. That is a lot of hassle and I'm not even sure anymore if it is that helpful. So I think I don't want to do that (at least not as part of this PR)

@jeriox jeriox requested a review from felixrindt March 5, 2025 17:17
@jeriox jeriox requested a review from felixrindt March 25, 2025 11:37
@jeriox jeriox force-pushed the participation-comment branch from e98ea80 to 73d71f9 Compare March 25, 2025 11:41
@jeriox jeriox force-pushed the participation-comment branch from f7d3d2a to 9b1785e Compare April 13, 2025 18:21
@jeriox jeriox enabled auto-merge (squash) April 13, 2025 18:22
@jeriox jeriox merged commit c93ddc1 into main Apr 13, 2025
14 checks passed
@jeriox jeriox deleted the participation-comment branch April 13, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[C] feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Internal participation comment for planners Reason for rejecting a participation

3 participants