Skip to content

Comments

Ujjwal/new moving window#285

Open
usinhampik wants to merge 109 commits intoepochpic:5.0-develfrom
FZJ-JSC:ujjwal/new_moving_window
Open

Ujjwal/new moving window#285
usinhampik wants to merge 109 commits intoepochpic:5.0-develfrom
FZJ-JSC:ujjwal/new_moving_window

Conversation

@usinhampik
Copy link

Dear Keith,
We would like to initiate a pull request for our branch to the main EPOCH repository. As the work was financially supported by PRACE, I have acknowledged it next to my name in the contributors.md file as I was not able to find any other place for acknowledgment. Please let me know if you need any information regarding our branch or discuss anything.
Thank you,
Ujjwal Sinha
(u.sinha@fz-juelich.de)

u.sinha@fz-juelich.de and others added 30 commits May 8, 2020 14:31
…elich.de:10022/SLPP/epoch/epoch-dev into ujjwal/new_moving_window
Requires checks that alignment w.r.t. steps indeed works. Has not been compiled.
force_ump needs checking as well.
The dependency between `window` <-> `diagnostics` is resolved using a
F08 SUBMODULE. This works, but is not nice on several levels. See
comments within `window.F90`. One problem being that a newer Fortran
standard is required.
A cleaner solution would be to move the one dependent variable.
This is much simpler and more in line with EPOCH's guidelines and other
patterns. The single dependent variable has been moved to `shared_data`.
…elich.de:10022/SLPP/epoch/epoch-dev into ujjwal/new_moving_window
@usinhampik usinhampik changed the base branch from main to 5.0-devel September 8, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants