Conversation
LiamPattinson
approved these changes
Feb 9, 2026
Collaborator
LiamPattinson
left a comment
LiamPattinson
left a comment
There was a problem hiding this comment.
This looks good, much cleaner than before! I'd be wary of over-parametrising in cases where the test isn't actually about the dual-interface, as an ideal unit test shouldn't concern itself with unrelated features, but I didn't see anything here that was overly concerning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to cull duplicate tests and replace with `pytest.mark.parametrize as seen in #100.
@LiamPattinson There are some tests here that didn't previously have duplicates but could do with potentially adding the parametrization to e.g.
test_dataset/test_arrays_with_no_grids. I'm not sure if we need to test both since they both use the same underlying backend but just something to consider.Resolves #100