Clarify how the seed is used to create the write key #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tripped over the word _interpret_ here on step 2, since the private key is a scalar i _guess_ you _could_ use it directly but that would skip the SHA512 hashing and clamping that is given in [key generation section of RFC803](https://www.rfc-editor.org/rfc/rfc8032#section-5.1.5). I think using the word _derive_ instead makes it clearer that this is more involved and less ambigous with the use of the word on step 4.
Collaborator
|
Thanks for the PR! I believe the hashing and clamping refers only to the public key derivation. The private key is just a randomly generated 256bit number, there is no further processing on it. Thus I believe the current wording is accurate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tripped over the word interpret here on step 2. Since the private key is a scalar i guess you could use it directly but that would skip the SHA512 hashing and clamping that is given in the key generation section of RFC8032.
I think using the word derive instead makes it clearer that this is more involved and less ambigous with the use of the word on step 4.