Skip to content

Refactor MockZMQServer signal into booleans#12937

Merged
eivindjahren merged 1 commit intoequinor:mainfrom
eivindjahren:refactor_mock_zeromq_signal
Feb 27, 2026
Merged

Refactor MockZMQServer signal into booleans#12937
eivindjahren merged 1 commit intoequinor:mainfrom
eivindjahren:refactor_mock_zeromq_signal

Conversation

@eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Feb 19, 2026

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

@eivindjahren eivindjahren added the release-notes:refactor PR changes code without changing ANY (!) behavior. label Feb 19, 2026
@eivindjahren eivindjahren force-pushed the refactor_mock_zeromq_signal branch from cb2e3d7 to 122686b Compare February 19, 2026 08:16
@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.51%. Comparing base (ab16644) to head (189198a).
⚠️ Report is 39 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12937      +/-   ##
==========================================
- Coverage   90.67%   90.51%   -0.16%     
==========================================
  Files         441      443       +2     
  Lines       30495    30596     +101     
==========================================
+ Hits        27650    27693      +43     
- Misses       2845     2903      +58     
Flag Coverage Δ
cli-tests 37.11% <ø> (-0.11%) ⬇️
gui-tests 67.70% <ø> (-0.08%) ⬇️
performance-and-unit-tests 77.01% <ø> (-0.13%) ⬇️
test 46.28% <ø> (+8.99%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eivindjahren eivindjahren force-pushed the refactor_mock_zeromq_signal branch from 122686b to 189198a Compare February 19, 2026 08:36
@eivindjahren eivindjahren self-assigned this Feb 19, 2026
@xjules
Copy link
Contributor

xjules commented Feb 19, 2026

Some failing tests, not sure if they are related though. @jonathan-eq has made a suggestion too and thus maybe he can do a review / combine both approaches.
Ref: #12807

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 19, 2026

Merging this PR will improve performance by 83.27%

⚡ 1 improved benchmark
✅ 33 untouched benchmarks

Performance Changes

Benchmark BASE HEAD Efficiency
test_direct_dark_performance[gen_x: 20, sum_x: 20 reals: 10-gen_data_with_obs-get_record_parquet] 40.2 ms 21.9 ms +83.27%

Comparing eivindjahren:refactor_mock_zeromq_signal (189198a) with main (c0bda0b)

Open in CodSpeed

Copy link
Contributor

@jonathan-eq jonathan-eq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eivindjahren eivindjahren merged commit b119765 into equinor:main Feb 27, 2026
67 of 69 checks passed
@eivindjahren eivindjahren deleted the refactor_mock_zeromq_signal branch February 27, 2026 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-notes:refactor PR changes code without changing ANY (!) behavior.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants