Skip to content

Remove endpoints only used by webviz-ert#12971

Open
frode-aarstad wants to merge 3 commits intoequinor:mainfrom
frode-aarstad:remove-webviz-ert-entries
Open

Remove endpoints only used by webviz-ert#12971
frode-aarstad wants to merge 3 commits intoequinor:mainfrom
frode-aarstad:remove-webviz-ert-entries

Conversation

@frode-aarstad
Copy link
Contributor

@frode-aarstad frode-aarstad commented Feb 25, 2026

Also remove some unused code and old webviz-ert testing

Issue
Resolves equinor/webviz-ert#503

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

Also remove some unused code and old webviz-ert testing
@frode-aarstad frode-aarstad self-assigned this Feb 25, 2026
@frode-aarstad frode-aarstad added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Feb 25, 2026
@frode-aarstad frode-aarstad force-pushed the remove-webviz-ert-entries branch from 1e5cb7c to 0570000 Compare February 25, 2026 10:52
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 25, 2026

Merging this PR will not alter performance

✅ 35 untouched benchmarks


Comparing frode-aarstad:remove-webviz-ert-entries (583ac25) with main (dd7b38c)

Open in CodSpeed



@pytest.mark.integration_test
def test_that_heat_equation_get_observations_with_locations(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to stay for the obs in field visualization

Copy link
Contributor

@xjules xjules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to discuss this first as the observation endpoints I'm planning to use for some localization related visualization (see. #12958).
Moreover, I thought sumo wants to be a consumer of observations too.

@frode-aarstad frode-aarstad added needs-discussion Issues requiring further discussions labels Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-discussion Issues requiring further discussions release-notes:maintenance Automatically categorise as maintenance change in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean up the dark-storage interface

2 participants