Skip to content

Remove logging of successful realizations in _evaluate_and_postprocess#12979

Open
andreas-el wants to merge 1 commit intoequinor:mainfrom
andreas-el:log_states_for_realizations
Open

Remove logging of successful realizations in _evaluate_and_postprocess#12979
andreas-el wants to merge 1 commit intoequinor:mainfrom
andreas-el:log_states_for_realizations

Conversation

@andreas-el
Copy link
Contributor

@andreas-el andreas-el commented Feb 26, 2026

Remove logging that only affected some of the simulation modes.
Have grepped json-output from grafana to see if this affects queries found in widgets.

Approach
✂️

(Screenshot of new behavior in GUI if applicable)

These messages produces these statistics that are not representative of how the state actually is.
Screenshot 2026-02-26 at 11 59 56

Rewritten query using other statements paint a very different picture.
Screenshot 2026-02-26 at 12 00 03

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

@andreas-el andreas-el added the release-notes:skip If there should be no mention of this in release notes label Feb 26, 2026
@andreas-el andreas-el self-assigned this Feb 26, 2026
@andreas-el andreas-el added this to SCOUT Feb 26, 2026
@andreas-el andreas-el moved this to Ready for Review in SCOUT Feb 26, 2026
@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.34%. Comparing base (3cbbcc9) to head (e99e2fe).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12979      +/-   ##
==========================================
+ Coverage   90.16%   90.34%   +0.17%     
==========================================
  Files         447      448       +1     
  Lines       31057    30997      -60     
==========================================
+ Hits        28002    28003       +1     
+ Misses       3055     2994      -61     
Flag Coverage Δ
cli-tests 36.91% <ø> (+0.06%) ⬆️
gui-tests 67.73% <ø> (+0.16%) ⬆️
performance-and-unit-tests 76.99% <ø> (+0.15%) ⬆️
test 46.10% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andreas-el andreas-el force-pushed the log_states_for_realizations branch from b221ebb to e99e2fe Compare February 26, 2026 14:13
@andreas-el andreas-el changed the title Removed logging of successful realizations in _evaluate_and_postprocess Remove logging of successful realizations in _evaluate_and_postprocess Feb 26, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 26, 2026

Merging this PR will not alter performance

✅ 35 untouched benchmarks


Comparing andreas-el:log_states_for_realizations (e99e2fe) with main (eca1c2a)

Open in CodSpeed

@andreas-el andreas-el enabled auto-merge (rebase) February 27, 2026 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-notes:skip If there should be no mention of this in release notes

Projects

Status: Ready for Review

Development

Successfully merging this pull request may close these issues.

2 participants