Skip to content

Breakthrough misfit#12987

Draft
SAKavli wants to merge 3 commits intoequinor:mainfrom
SAKavli:breakthrough-misfit
Draft

Breakthrough misfit#12987
SAKavli wants to merge 3 commits intoequinor:mainfrom
SAKavli:breakthrough-misfit

Conversation

@SAKavli
Copy link
Contributor

@SAKavli SAKavli commented Feb 27, 2026

Issue
Resolves #12968

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

To be more similar to summary responses, the breakthrough
responses benefits from having the observed date as their "time"
values as this is how to match responses with observations
in for example the plotter.
@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.36%. Comparing base (f684095) to head (7f78863).
⚠️ Report is 14 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12987      +/-   ##
==========================================
+ Coverage   90.12%   90.36%   +0.24%     
==========================================
  Files         447      453       +6     
  Lines       30972    31143     +171     
==========================================
+ Hits        27914    28143     +229     
+ Misses       3058     3000      -58     
Flag Coverage Δ
cli-tests 37.21% <0.00%> (+0.45%) ⬆️
gui-tests 67.78% <100.00%> (+0.33%) ⬆️
performance-and-unit-tests 77.02% <100.00%> (+0.24%) ⬆️
test 46.21% <0.00%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 27, 2026

Merging this PR will not alter performance

✅ 35 untouched benchmarks


Comparing SAKavli:breakthrough-misfit (7f78863) with main (a7dc914)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix misfit values for breakthrough observations

2 participants