filter_kubernetes: fix memory leak and allow configurable cache size #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses a memory leak issue and unbounded cache growth in the kubernetes filter plugin. Changes: - Add `kube_meta_cache_size` configuration option. This allows users to configure the size of the metadata cache hash table. - Update `kube_conf.c` to use the configured cache size for initialization. - Fix memory leak in `kube_meta.c` where `tmp_hash_meta_buf` was not freed if `flb_hash_table_add` failed in `flb_kube_pod_meta_get` and `flb_kube_namespace_meta_get`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses a memory leak issue and unbounded cache growth in the kubernetes filter plugin.
Changes:
kube_meta_cache_sizeconfiguration option. This allows users to configure the size of the metadata cache hash table.kube_conf.cto use the configured cache size for initialization.kube_meta.cwheretmp_hash_meta_bufwas not freed ifflb_hash_table_addfailed inflb_kube_pod_meta_getandflb_kube_namespace_meta_get.Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.