Skip to content

UIDevice-Hardware updates #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
chaitanyagupta wants to merge 8 commits into
base: master
Choose a base branch
from
Open

UIDevice-Hardware updates #15

chaitanyagupta wants to merge 8 commits into from

Conversation

@chaitanyagupta
Copy link

@chaitanyagupta chaitanyagupta commented Apr 26, 2012

A couple of changes to UIDevice-Hardware:

  1. Returns "iPhone 4S" instead of "iPhone 5"
  2. Add newline at the end of files to avoid pedantic warnings and noise from tools like diff.

Review on Reviewable

@vvineet0505
Copy link

vvineet0505 commented Mar 20, 2013

Error: Returns UIDevice1GiPad for iPhone5 :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@foadhassanzadeh foadhassanzadeh foadhassanzadeh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@chaitanyagupta @vvineet0505 @foadhassanzadeh @AbhaySingh @yatinsns