Fix getDerivedStateFromProps to handle simultaneous allowNegative and format prop changes #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is no change log for this pull request yet. |
Merged
… format prop changes Co-authored-by: ericblade <1451847+ericblade@users.noreply.github.com>
Co-authored-by: ericblade <1451847+ericblade@users.noreply.github.com>
Co-authored-by: ericblade <1451847+ericblade@users.noreply.github.com>
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Add more tests in response to feedback on PR #45
Fix getDerivedStateFromProps to handle simultaneous allowNegative and format prop changes
Dec 14, 2025
ericblade
approved these changes
Dec 14, 2025
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in getDerivedStateFromProps where simultaneous changes to allowNegative and format props (like prefix, suffix, or separators) would result in negative values not being converted to positive when allowNegative is disabled. The fix unifies the handling of format changes and allowNegative changes into a single code path, ensuring both are processed correctly.
Key changes:
- Unified prop change handling by including
allowNegativeChangedin theformatChangedcondition - Added value conversion logic that checks if a negative value needs to be converted to positive before applying format changes
- Added comprehensive test coverage for the simultaneous prop change scenario
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/base.spec.ts | Adds test case validating that disabling allowNegative while simultaneously changing the prefix correctly converts negative values to positive and applies the new prefix |
| src/index.tsx | Refactors getDerivedStateFromProps to handle allowNegative changes within the unified format change handler, preventing the early return issue that bypassed negative-to-positive value conversion |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sequential if-statements with early returns in
getDerivedStateFromPropscaused theallowNegativechange handler to be bypassed when format props also changed simultaneously, leaving negative values unconverted to positive.Changes
allowNegativeChangedin theformatChangedcondition so both are handled in a single code pathallowNegativeandprefixchangesExample
When both
allowNegativeandprefixchange (e.g., user unchecks "Allow negative" and changes prefix from "$" to "€"), the value-50.00now correctly becomes€50.00instead of remaining€-50.00.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.