ISSUE-165: ensure that /startapp.sh compiles 42#173
Merged
ericstoneking merged 1 commit intomasterfrom May 21, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue(s):
#165 : ensure that /startapp.sh compiles 42 in podman/docker
This ticket has no impact on 42's native code base. This implementation Closes #165
Overview:
Altered startapp.sh to
make clean && make -j2to ensure that 42 is compiled and ready for use or is already runningVerify
run
make build upthen go to http://localhost:5801/vnc.html and confirm that 42 has already been compiled and is running or is runnable.Expected Results:
When 42 starts in http://localhost:5801/vnc.html the 42 is compiled and running.
Dependencies:
N/A
Optional
N/A
Known issue(s)
N/A