Michael shooting (with moving functionality)#43
Conversation
…uilt2026 into anshu-commands
it does seem to kinda work tho
|
it works if you are not going that fast, so I reduced the max speed to 2/3 when not shooting but in alliance zone, and 1/3 when shooting might want a trigger to remove this, or just get arid of the aiming functionality alltogeter actually imma do that one sec kk the aiming functionality is commented out now, but still usable in case we ever want it again still max speed of 1/3 when shooting, might need to be changed later but max speed of even 1/5 normal is better than 0 |
|
also nice job anshu |
this should probs be in the other shoot command too
|
also jsut realized that the code works exactly the same as the normal one if we set the max shooting speed to 0, so I am just going to remove the "shoot on move" variable, and add a comment to it |
…tant just need to reverse the hopper after shooting is done and I will be happy
|
#45 should eventually be fixed but idk how so yeah ill do that maybe later |
all the tested positions should be in the units library and not doubles, but im too lazy to change that rn
themehdev
left a comment
themehdev
left a comment
There was a problem hiding this comment.
hopper should be run backward for a bit after shooting is done, shooter constants should be updated to be distances, d-pad probably shouldnt interrupt the shoot command (but there is a chance this ends up being useful if it works how I think it will work, so maybe not), but none of these are breaking and can be done later, so id say it is good to be merged in
should probably test to make sure setting the gp to null doesnt cause any problems, but I dont think it should
|
Marking this as draft because we decided not to merge this in at the moment, but when we get to the time when we would like to, some changes will need to be made of course to update to main, and then we will review and test these on a real robot. |
|
What changes will need to be made before this can be merged into main? I think that this is ready to be merged in, as it has all the needed functionality to support both shooting on and off the move. The argument that this still needs to be tested on the real robot (normal shooting code and moving while shooting code) does not hold up, as basically everything on main right now has not been tested on a real robot. I don't see why this cannot be merged in as of now. |
|
Most things on main have been tested on a real robot. The problem especially is that there will be merge conflicts in the future, and we don't intend on having this extra code we aren't using until we'd like to use it, as we have a main shooting branch we would like to merge in and test first. There is no harm in keeping this in our back pockets until we would like to test it, because right now it is simpler to edit and debug without an added lever of complexity. |
|
yeah, but what I am saying is that the main shooting functionality without moving is different enough that i this one should be used for just shooting so then it is easier to make the switch to shooting on the move when we want to test it just to be clear, the entire reason I think that this should be merged is because of the normal shooting functionality as well as the shooting on move funcitonality, so that when we want to test shooting on move and possibly even switching to shooting on move, we don't have to do it twice. this branch currently has the exact same or better functionality than anshu's does; there is nothing we are losing by using this one instead. I agree that shooting first should be tested and that shooting on move is a later thing, just this one is able to make the switch easier. |
|
We should decide what to do with anshu and pranav, there are a couple things that I would like to be different if we used this branch, but let's fix those after we have a discussion. |
themehdev
changed the title
4 participants
uhm idk it kinda works but not really
idk what the prob is tho, ill work on this more tomorrow