Clean up commands to be concise, improving development across codebase.#60
Merged
Clean up commands to be concise, improving development across codebase.#60
Conversation
kausikbs
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to write the commands for preloading, I was getting a headache trying to wrap my head around how our commands were structured, and would have ended up changing how the commands worked, so before we have to write all of those features, commands should be cleaned up a little bit, allowing for easier command groups and parallels, where subsystem state is cleanly maintained.
Most commands should start when they start, and when they end, the subsystem should be in a state where no commands are running, doing nothing. Currently, there are many excess commands that arent used currently, and not in any current PR's that do not follow this, meaning using them could result in a unknown state between commands running, meaning a command may not do what it is expected to do based on previous commands that have run, this is a problem because when we run a command, we should be able to expect the state of the subsystem based on running it, and these make that unpredictable if we were to use them, along with the fact that we don't use them.