Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds 64-bit support to quakegeneric. It has been tested on x86_64 (under WSL2) and aarch64 (custom OS on custom device). At least the first few levels are playable without errors and I suspect the rest is too.
The main change is around dynamically allocating several variables which were previously statically defined, to ensure that the pointer differences between them is small and consistently positive. The rationale is described in quakegeneric.c pasted below:
Quake uses eval_t members to point to the string table. For compatibility with loading
from disk these pointers are 4 bytes.
This leads to slightly unclean code in that we need to be able to access mod_known and pr_string_temp from quakegeneric.c to update them, but it seems to work for now.