Fix compiler version detection in bundle job #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Take it from inputs Greater 0.8.0 implies using store version 4 Fix postinstall statement when esy.rewritePrefix is false
ManasJayanth
changed the title
ManasJayanth
deleted the
prometheansacrifice/fix-compiler-version-detection-in-bundle-job
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need the compiler version to calculate the prefix path during preparation of NPM tarballs for different platforms and bundling into one tarball later. In the former stage, we need to rewrite prefixes and in the latter, to generate the postinstall.js script which would correctly rewrite the prefix again on the target machine.