Skip to content

Conversation

@nwnt
Copy link
Member

@nwnt nwnt commented Dec 16, 2025

Adding a small unit test as a small start step for #20386

cc @serathius @joshjms

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nwnt
Once this PR has been reviewed and has the lgtm label, please assign serathius for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Dec 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.11%. Comparing base (6a744e2) to head (7eb38a6).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files

see 19 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #21025      +/-   ##
==========================================
+ Coverage   69.08%   69.11%   +0.03%     
==========================================
  Files         422      422              
  Lines       34841    34841              
==========================================
+ Hits        24069    24081      +12     
+ Misses       9366     9350      -16     
- Partials     1406     1410       +4     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a744e2...7eb38a6. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Nont <nont@duck.com>
@nwnt nwnt force-pushed the add-txn-rangelimit-test branch from 2ae8ab1 to 7eb38a6 Compare December 16, 2025 14:40
@nwnt
Copy link
Member Author

nwnt commented Dec 16, 2025

The lint error is now fixed.

@k8s-ci-robot
Copy link

@nwnt: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-coverage-report 7eb38a6 link true /test pull-etcd-coverage-report

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@serathius
Copy link
Member

serathius commented Dec 16, 2025

Tests should cover whole range execution, not just rangeLimit function that will be might not be used in the future.

For regression testing you want to run as high level test as possible to prove that changing implementation below doesn't change the output.

@nwnt
Copy link
Member Author

nwnt commented Dec 16, 2025

Yep, I can add the whole tests for range. Thought I was going to start adding them one by one to keep the PRs small, but I can do that too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants