Allow overriding output in loader options#165
Open
klausweiss wants to merge 1 commit intoethul:masterfrom
Open
Allow overriding output in loader options#165klausweiss wants to merge 1 commit intoethul:masterfrom
klausweiss wants to merge 1 commit intoethul:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey. A new version of Spago is in the works (see https://github.com/purescript/spago) and it no longer supports
spago path outputas a way to tell the path to the output dir.This PR is a stopgap. While it does not provide a way to get that path with the new spago version, it allows to override the logic of getting it with
spago path outputby acceptingoutputas a loader param and using that if it's present.Also thanks for your work on the loader! It really eliminates friction from purs development for the web.