Use a longer timeout when removing a mirror #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default timeout of 10 seconds might be too short when removing a mirror, as it's a lenghty operation: mirrorbits needs to remove all the keys associated with the mirror from the database. The number of keys is roughly equal to the number of files tracked on the mirror. On the Kali mirrorbits instance we hit the timeout pretty much every time we remove a mirror. This has not always been the case, so I suppose we were close to the 10 seconds timeout, and then we crossed it (maybe the instance is more busy these days, or maybe it happened after we switched from redis to valkey). Close: etix#206
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default timeout of 10 seconds might be too short when removing a mirror, as it's a lenghty operation: mirrorbits needs to remove all the keys associated with the mirror from the database. The number of keys is roughly equal to the number of files tracked on the mirror.
On the Kali mirrorbits instance we hit the timeout pretty much every time we remove a mirror. This has not always been the case, so I suppose we were close to the 10 seconds timeout, and then we crossed it (maybe the instance is more busy these days, or maybe it happened after we switched from redis to valkey).
Close: #206