Add more debug info when hand_counts assertion fails.#1384
Open
NebuPookins wants to merge 2 commits intoetternagame:developfrom
Open
Add more debug info when hand_counts assertion fails.#1384NebuPookins wants to merge 2 commits intoetternagame:developfrom
NebuPookins wants to merge 2 commits intoetternagame:developfrom
Conversation
Member
|
This change isn't acceptable because it's making a breaking API change. Without the additional string parameter, it would be fine. However, this pr is more of a report of an actual programming problem. So I went ahead and fixed it: 164bd55 |
Author
|
Thanks for the fix. I wasn't aware that this API is "public". Are there external third parties that call into these APIs? |
Member
|
Everything behind define |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been getting some assertion failures like:
which I think might be related to PumpItUp charts. I don't fully understand what the hand_counts logic is doing. But in the meantime, I've updated the assertion message to print out some more info. In particular, I made it print out the name of the file that's triggering the assertion failure. This required adding an extra parameter to several methods so that the filename is passed up the call chain.
The new error message looks like this:
The main benefit of this is that now that we have a filename, it's possible to inspect the file to see what may have gone wrong. So far, every instance I've seen of triggering this assertion failure seems to be related to having a PumpItUp Chart.