Skip to content

Txs, transfers and outputs querying consolidation#49

Merged
everoddandeven merged 1 commit intomainfrom
rpc-wallet-consolidation-2
Mar 3, 2026
Merged

Txs, transfers and outputs querying consolidation#49
everoddandeven merged 1 commit intomainfrom
rpc-wallet-consolidation-2

Conversation

@everoddandeven
Copy link
Owner

Txs, transfers and outputs querying consolidation

  • Implement MoneroWalletRpc::sweep_unlocked
  • Implement test_monero_wallet_model unit tests
  • Fix MoneroWalletRpc::sweep_output, MoneroWalletRpc::sweep_account, MoneroWalletRpc::get_outputs_aux, PyMoneroWalletRpc::verify_message
  • Fix tx query reference in transfer and output query
  • Add wallet get_tx(const std::string&) and get_txs(const std::vector<string>&) convenience methods
  • Fix MoneroWallet::verify_message to return bad result for consistency
  • Fix wallet data model deserialization

@everoddandeven everoddandeven force-pushed the rpc-wallet-consolidation-2 branch from 4194b4f to 4390cd3 Compare March 2, 2026 22:27
* Implement `MoneroWalletRpc::sweep_unlocked`
* Implement `test_monero_wallet_model` unit tests
* Fix `MoneroWalletRpc::sweep_output`, `MoneroWalletRpc::sweep_account`, `MoneroWalletRpc::get_outputs_aux`, `PyMoneroWalletRpc::verify_message`
* Fix tx query reference in transfer and output query
* Add wallet `get_tx(const std::string&)` and `get_txs(const std::vector<string>&)` convenience methods
* Fix `MoneroWallet::verify_message` to return bad result for consistency
* Fix wallet data model deserialization
@everoddandeven everoddandeven force-pushed the rpc-wallet-consolidation-2 branch from 4390cd3 to 3a42adf Compare March 2, 2026 23:22
@codacy-production
Copy link

codacy-production bot commented Mar 2, 2026

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+4.98% (target: -1.00%) 89.04%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (1adbf7b) 13569 9849 72.58%
Head commit (3a42adf) 14874 (+1305) 11537 (+1688) 77.56% (+4.98%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#49) 1424 1268 89.04%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@everoddandeven everoddandeven merged commit 703980f into main Mar 3, 2026
4 of 5 checks passed
@everoddandeven everoddandeven deleted the rpc-wallet-consolidation-2 branch March 3, 2026 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant