Fix: Expand variables in included fragments / files #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I think this needs an update to ab59736 (which I think you need to rebase onto) |
Author
|
I believe my repo is already up to date with that commit? 
|
evmar
reviewed
Nov 1, 2025
| }; | ||
|
|
||
| let mut combined_envs: Vec<&dyn eval::Env> = vec![&parser.vars]; | ||
| combined_envs.extend(envs); |
Owner
There was a problem hiding this comment.
It looks like you never use this (?)
evmar
reviewed
Nov 1, 2025
Owner
evmar
left a comment
evmar
left a comment
There was a problem hiding this comment.
If you fixed the issue, the test I mentioned should be affected by this change. It has the fixed code commented out too
Author
|
Oh my apologies, the unused variable was an oversight, I must've accidentally undone some changes, and I thought the testing case was already testing for the correct behavior. I'll push a fix soon! |
Author
|
Closing this since my fix didn't resolve the issue, and I'm going to be busy for a while. @olivia-banks will submit a new PR with a working solution soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #145
As per the comment in issue #145, marginally change the API to pass
envsthrough.read_file()and.parse(), then parse file contents using that context.